-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loot&
and transfer&
commands
#3287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than mentioned concerns it looks good 🙂
0341ef8
to
ff3ec8f
Compare
@JustArchi, thanks a lot for the suggestions! Hope I got them right. |
ff3ec8f
to
39eab87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I looked at the code and it looks fine (no wonder after Abrynos' and Archi's reviews), but to be honest I don't understand reasoning behind those commands and chosen way in which they work. First of all, ASF is a card farming app, not general account management tool, shouldn't it be in a plugin instead? And, secondly, why we try to convert rarities to enum, instead of just filtering by internal name (how user is supposed to know this name is another question, but understanding the match between enum and shown rarity is not straighforward anyway, if I understand it right). If we pick by internal name, wouldn't it be more generic and applicable to any game inventory, not just to Valve's games? |
As I stated earlier, added commands are derivatives of
Some variation of this where we can state the list of all available rarities, aliases and internal names.
I don't think it would be a good idea to have something like |
Still possible to extract them into official plugin shipped with ASF 😉 |
Thanks for your contribution 🏆 |
Checklist
Changes
New functionality
Adds two derivatives of
loot^
andtransfer^
commands:loot&
andtransfer&
, allowing one to transfer Steam items that match user-provided set ofEAssetRarity
.Additional info
This implementation expands the current
EAssetRarity
enum with rarities inherent in official Valve games, namely: CS2, DOTA2 and TF2, as well as some non-Valve games that I'm somewhat familiar with (eg. PAYDAY2). Covering every possible item rarity in non-Valve games that support Steam Inventory Service is pretty unrealistic since, to my knowledge, there's no strict naming conventions.Some clarifications:
Seasonal
(DOTA2) andDefault
rarities are intentionally omitted, they are not tradable.tag.category.ToUpperInvariant()
is used because non-Valve games tend to have lowercaserarity
category. Conversely, the same category in Valve games isRarity
.Also, I'm not sure about
Arcana
rarity. It is DOTA2 specific, maybe it would be better to combine it withUnusual
? Would greatly appreciate any kind of feedback.